Added DAMAGE.FLASH_COLOUR field for custom flash colors #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akaAgar
changed the title
dashodanger
added
needs testing
|
We need to test this to make sure it plays nice when there are other effects in action etc. Great idea by the way! |
dashodanger
removed
the
needs testing
|
Looks good; tested with various effects (invuln, berserk, rad suit) and it looks like it respects the custom color in all cases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using the field DAMAGE.FLASH_COLOUR (RGB value) in ATTACKS.DDF, it is now possible to specify a custom damage flash colour to display when the player is hit by an attack. Can be used to emulate Hexen's cold/poison color flashes.