Skip to content
This repository has been archived by the owner on Apr 23, 2021. It is now read-only.

update kong image #273

Merged
merged 4 commits into from
Oct 3, 2019
Merged

Conversation

ernestojeda
Copy link
Contributor

I am updating the arm64_env file to update the docker kong image to the latest arm64 based version. This is an attempt to fix the exec format error due to the previous image being based on 32bit arm. The build of the image can be found here: https://jenkins.edgexfoundry.org/view/CI-Build-Images/job/ci-build-images-kong-merge-pipeline/64/

Signed-off-by: Ernesto Ojeda [email protected]

Signed-off-by: Ernesto Ojeda <[email protected]>
@ernestojeda
Copy link
Contributor Author

ernestojeda commented Sep 26, 2019

Fixes #185 and #17

@jamesrgregg
Copy link
Contributor

@cloudxxx8 @cherrycl please review this one at your earliest convenience. I don't have permissions to add reviewers on this repo.

@ernestojeda
Copy link
Contributor Author

I setup a test job on the sandbox for this PR and it is still failing with the exec format error: https://jenkins.edgexfoundry.org/sandbox/job/blackbox-testing-security-ubuntu18.04-docker-arm64-4c-2g-master/6/consoleFull. I am going to debug this issue a bit more.

…hat command fails, use kong migrations up

Signed-off-by: Ernesto Ojeda <[email protected]>
jamesrgregg
jamesrgregg previously approved these changes Sep 27, 2019
Copy link
Contributor

@jamesrgregg jamesrgregg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hutchic
Copy link
Member

hutchic commented Oct 1, 2019

curious why EdgeX couldn't use kong:ubuntu? Why duplicate building Kong for arm64 from source?

Signed-off-by: Ernesto Ojeda <[email protected]>
@ernestojeda
Copy link
Contributor Author

ernestojeda commented Oct 2, 2019

curious why EdgeX couldn't use kong:ubuntu? Why duplicate building Kong for arm64 from source?

I am not sure how to answer this except maybe that at the time that this repository was setup the arm64 image did not exist and someone pointed us to this Dockerfile by someone in the community: https://github.com/svenwal/kong-arm/blob/master/Dockerfile.

Anyway, I switched everything over to the kong:1.3.0-ubuntu image and it all still seems to work.

Here is the job running on the sandbox:
https://jenkins.edgexfoundry.org/sandbox/view/All/job/blackbox-testing-security-ubuntu18.04-docker-arm64-4c-2g-master/1/consoleFull

@andyf1967 andyf1967 merged commit a3a41be into edgexfoundry:master Oct 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants