Merge pull request #1629 from jinlinGuan/issue-1520

fix: Change status code to 400 for write commands with invalid values
edgexfoundry · Oct 2, 2024 · 63adea8 · 63adea8
2 parents 0f2c62f + 44ddd41
commit 63adea8
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/internal/application/command.go b/internal/application/command.go
@@ -287,7 +287,7 @@ func writeDeviceResource(device models.Device, resourceName string, attributes s
 	// create CommandValue
 	cv, edgexErr := createCommandValueFromDeviceResource(dr, v)
 	if edgexErr != nil {
-		return nil, errors.NewCommonEdgeX(errors.Kind(edgexErr), "failed to create CommandValue", edgexErr)
+		return nil, errors.NewCommonEdgeX(errors.KindContractInvalid, "failed to create CommandValue", edgexErr)
 	}
 
 	// prepare CommandRequest
@@ -385,7 +385,7 @@ func writeDeviceCommand(device models.Device, commandName string, attributes str
 		if err == nil {
 			cvs = append(cvs, cv)
 		} else {
-			return nil, errors.NewCommonEdgeX(errors.Kind(err), "failed to create CommandValue", err)
+			return nil, errors.NewCommonEdgeX(errors.KindContractInvalid, "failed to create CommandValue", err)
 		}
 	}