-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove requests dependency #152
Draft
Mr0grog
wants to merge
11
commits into
main
Choose a base branch
from
58-if-requests-is-not-thread-safe-we-are-not-thread-safe-and-that-makes-us-unhappy
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Remove requests dependency #152
Mr0grog
wants to merge
11
commits into
main
from
58-if-requests-is-not-thread-safe-we-are-not-thread-safe-and-that-makes-us-unhappy
Commits on Dec 18, 2023
-
Start the messy path to removing requests
This starts the path toward removing the requests package by rejiggering *most* of our exception handling. There is a huge amount more to do and this doesn't even begin to start using urllib3 to make requests, so basically everything should be completely broken with this commit. Part of #58.
Configuration menu - View commit details
-
Copy full SHA for 620a64f - Browse repository at this point
Copy the full SHA 620a64fView commit details -
A horrifying implementation that passes tests
We can refine from here. Lots of bad things that need cleanup, and, well, maybe just too much stuff in general.
Configuration menu - View commit details
-
Copy full SHA for 5963af2 - Browse repository at this point
Copy the full SHA 5963af2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9ce638a - Browse repository at this point
Copy the full SHA 9ce638aView commit details -
Rename
ok
tois_success
on InternalHttpResponseTaking some inspiration from httpx here, which I think had good reasoning for this change from requests.
Configuration menu - View commit details
-
Copy full SHA for b3abbf9 - Browse repository at this point
Copy the full SHA b3abbf9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 34effec - Browse repository at this point
Copy the full SHA 34effecView commit details -
Configuration menu - View commit details
-
Copy full SHA for a78d180 - Browse repository at this point
Copy the full SHA a78d180View commit details -
Create new
_http
module for HTTP stuffThis also moves the crazy gzip hack there for a start.
Configuration menu - View commit details
-
Copy full SHA for 193ee16 - Browse repository at this point
Copy the full SHA 193ee16View commit details -
Configuration menu - View commit details
-
Copy full SHA for 99c34f0 - Browse repository at this point
Copy the full SHA 99c34f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1464230 - Browse repository at this point
Copy the full SHA 1464230View commit details -
Configuration menu - View commit details
-
Copy full SHA for 358e036 - Browse repository at this point
Copy the full SHA 358e036View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8775f2c - Browse repository at this point
Copy the full SHA 8775f2cView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.