N11 - fix: correct relative dates flag #645
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaferMazu
force-pushed
the
N11-relative-dates-flag
branch
from
07afe7e
to
83c23c2
Compare
|
About the adjustements i made. some of these was module imports, add missing files and fix tests. WafflerFlags is being used a different structure than ours. but essentially does the same thing (They basically made his class where they used methods like overwrite and we use the overwrite as decorator). I just added the missing overwrite in our structure with their logic and change it in the tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Correct relative dates flag and use CourseWaffleFlag
Other info
Juniper commits:
fccn/edx-platform@84412e2
fccn/edx-platform@573a826
Jira issue
Migration excel