Skip to content

Commit

Permalink
fix: Don't assume there is a context.
Browse files Browse the repository at this point in the history
Don't assume that there will be an extra `context` kwarg when using the
bookmark serializer.  We use it this way in the current code but that's
specific to us and not comon to all serializers.  There are a lot of API
documentation tools that automate introspecting serializers but they
won't know  that they have to send in a `context` to the serializer.

To make this serializer behave more like other serializers without
changing the behavior, we just need to check that the `context` value is
defined before we dig into it.  In the case that there is no `context`
we just treat it the same as if there is no `request` in the `context`.
  • Loading branch information
feanil committed Jun 29, 2023
1 parent 79a4339 commit cf9c4e8
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion openedx/core/djangoapps/bookmarks/serializers.py
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ def __init__(self, *args, **kwargs):
# Drop any fields that are not specified in the `fields` argument.
required_fields = set(fields)

if 'request' in kwargs['context'] and is_schema_request(kwargs['context']['request']):
if 'context' in kwargs and 'request' in kwargs['context'] and is_schema_request(kwargs['context']['request']):
# We are serving the schema: include everything
required_fields.update(OPTIONAL_FIELDS)

Expand Down

0 comments on commit cf9c4e8

Please sign in to comment.