feat: adding settings to enable SCORM storage backend #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfavellar90
reviewed
Jun 1, 2022
| @@ -1049,3 +1049,19 @@ def get_env_setting(setting): | |||
| 'openedx.core.djangoapps.coursegraph.dump_course_to_neo4j': { | |||
| 'queue': COURSEGRAPH_JOB_QUEUE}, | |||
| } | |||
|
|
|||
| from storages.backends.s3boto import S3BotoStorage | |||
There was a problem hiding this comment.
@DonatoB-eduNEXT I'm wondering if we would require an extra layer of validation here. I know the storage likely won't change in the future but what if the platform no longer supports S3BotoStorage because of a configuration change? We could validate if the setting DEFAULT_FILE_STORAGE in Django matches any of the storages supported by SCORM, and then you can return the proper storage object. It's not a must-have, but it would strengthen the implementation. It would apply for both files, LMS and CMS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom backend added