Skip to content

Commit

Permalink
refactor: apply pr suggestions
Browse files Browse the repository at this point in the history
  • Loading branch information
andrey-canon committed Aug 8, 2023
1 parent fa4f81d commit 2b28833
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions eox_nelp/signals/tests/test_receivers.py
Original file line number Diff line number Diff line change
Expand Up @@ -107,18 +107,18 @@ def setUp(self):

@override_settings(ENABLE_CERTIFICATE_PUBLISHER=False)
@patch("eox_nelp.signals.receivers.create_external_certificate")
def test_inactive_behavior(self, mock_task):
def test_inactive_behavior(self, create_external_certificate_mock):
"""Test that the asynchronous task wont' be called when the setting is not active.
Expected behavior:
- create_external_certificate is not called
"""
certificate_publisher(self.certificate_data, self.metadata)

mock_task.delay.assert_not_called()
create_external_certificate_mock.delay.assert_not_called()

@patch("eox_nelp.signals.receivers.create_external_certificate")
def test_invalid_mode(self, mock_task):
def test_invalid_mode(self, create_external_certificate_mock):
"""Test when the certificate data has an invalid mode.
Expected behavior:
Expand Down Expand Up @@ -154,14 +154,14 @@ def test_invalid_mode(self, mock_task):
with self.assertLogs(receivers.__name__, level="INFO") as logs:
certificate_publisher(certificate_data, self.metadata)

mock_task.delay.assert_not_called()
create_external_certificate_mock.delay.assert_not_called()
self.assertEqual(logs.output, [
f"INFO:{receivers.__name__}:{log_info}"
])

@patch("eox_nelp.signals.receivers._generate_external_certificate_data")
@patch("eox_nelp.signals.receivers.create_external_certificate")
def test_create_call(self, mock_task, generate_data_mock):
def test_create_call(self, create_external_certificate_mock, generate_data_mock):
"""Test when the certificate mode is valid and the asynchronous task is called
Expected behavior:
Expand All @@ -185,7 +185,7 @@ def test_create_call(self, mock_task, generate_data_mock):
timestamp=self.metadata.time,
certificate_data=self.certificate_data,
)
mock_task.delay.assert_called_with(
create_external_certificate_mock.delay.assert_called_with(
external_certificate_data=generate_data_mock()
)
self.assertEqual(logs.output, [
Expand All @@ -195,7 +195,7 @@ def test_create_call(self, mock_task, generate_data_mock):
@override_settings(CERTIFICATE_PUBLISHER_VALID_MODES=["another-mode"])
@patch("eox_nelp.signals.receivers._generate_external_certificate_data")
@patch("eox_nelp.signals.receivers.create_external_certificate")
def test_alternative_mode(self, mock_task, generate_data_mock):
def test_alternative_mode(self, create_external_certificate_mock, generate_data_mock):
"""Test when the certificate data has an alternative mode.
Expected behavior:
Expand Down Expand Up @@ -236,7 +236,7 @@ def test_alternative_mode(self, mock_task, generate_data_mock):
timestamp=self.metadata.time,
certificate_data=certificate_data,
)
mock_task.delay.assert_called_with(
create_external_certificate_mock.delay.assert_called_with(
external_certificate_data=generate_data_mock()
)
self.assertEqual(logs.output, [
Expand Down

0 comments on commit 2b28833

Please sign in to comment.