feat: use query params in snake case

eduNEXT · Jul 5, 2023 · 4c85d62 · 4c85d62
1 parent 614f910
commit 4c85d62
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 18 deletions.
diff --git a/eox_nelp/stats/templates/tenant_stats.html b/eox_nelp/stats/templates/tenant_stats.html
@@ -8,11 +8,11 @@
 <body>
     <div id="tenant-stats"></div>
     <script>
-      var showVideos = "true" === "${showVideos}";
-      var showCourses = "true" === "${showCourses}";
-      var showProblems = "true" === "${showProblems}";
-      var showLearners = "true" === "${showLearners}";
-      var showInstructors = "true" === "${showInstructors}";
+      var showVideos = "true" === "${show_videos}";
+      var showCourses = "true" === "${show_courses}";
+      var showProblems = "true" === "${show_problems}";
+      var showLearners = "true" === "${show_learners}";
+      var showInstructors = "true" === "${show_instructors}";
     </script>
     <script src="${static.url('tenant_stats/js/tenant_stats.js')}"></script>
 </body>

diff --git a/eox_nelp/stats/tests/test_views.py b/eox_nelp/stats/tests/test_views.py
@@ -37,7 +37,7 @@ def test_get_default_stats(self):
         self.assertEqual(self.template_name, response.templates[0].name)
         self.assertContains(response, '<div id="tenant-stats"></div')
 
-    @data("showVideos", "showCourse", "showProblems", "showInstructors", "showLearners")
+    @data("show_videos", "show_course", "show_problems", "show_instructors", "show_learners")
     def test_get_specific_stat(self, query_param):
         """
         Test that the view render successfully when a query param is included

diff --git a/eox_nelp/stats/views.py b/eox_nelp/stats/views.py
@@ -15,25 +15,25 @@ def get_tenant_stats(request):
     By default this show nothing since this requires the specific query para to show the content.
 
     Examples:
-        renders just video card /eox-nelp/stats/tenant/?showVideos=true
+        renders just video card /eox-nelp/stats/tenant/?show_videos=true
 
         render multiple components
-        /eox-nelp/stats/tenant/?showVideos=true&showCourses=true&showInstructors=true
+        /eox-nelp/stats/tenant/?show_videos=true&show_courses=true&show_instructors=true
 
     The available options are:
-        showVideos
-        showCourses
-        showLearners
-        showInstructors
-        showProblems
+        show_videos
+        show_courses
+        show_learners
+        show_instructors
+        show_problems
     """
 
     context = {
-        "showCourses": "false",
-        "showVideos": "false",
-        "showProblems": "false",
-        "showLearners": "false",
-        "showInstructors": "false",
+        "show_courses": "false",
+        "show_videos": "false",
+        "show_problems": "false",
+        "show_learners": "false",
+        "show_instructors": "false",
     }
     context.update(request.GET.dict())