-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #87 from eduNEXT/jlc/update-certificates-referenceid
feat: add national_id validation for reference_id
- Loading branch information
Showing
5 changed files
with
198 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,6 +5,7 @@ | |
""" | ||
import unittest | ||
|
||
from ddt import data, ddt | ||
from django.conf import settings | ||
from django.contrib.auth import get_user_model | ||
from django.test import override_settings | ||
|
@@ -17,6 +18,9 @@ | |
|
||
User = get_user_model() | ||
|
||
WRONG_NATIONAL_IDS = [0, "", "324234", "VADER", "3666888999", "166688899", "فيدر"] | ||
SAML_EXTRA_ASSOCIATIONS_LIST = ["1666888998ASDF", "1222666444a6ca", "12226664443242344334534543", "1222666444#@$%"] | ||
|
||
|
||
class UserHasPassingGradeTestCase(unittest.TestCase): | ||
"""Test class for function `_user_has_passing_grade`""" | ||
|
@@ -37,13 +41,14 @@ def test_call_user_has_passing_grade(self, course_grade_factory_mock): | |
course_grade_factory_mock().read.assert_called_with(user, course_key=CourseKey.from_string(course_id)) | ||
|
||
|
||
@ddt | ||
class GenerateExternalCertificateDataTestCase(unittest.TestCase): | ||
"""Test class for function `_generate_external_certificate_data`""" | ||
|
||
def setUp(self): | ||
""" Set common conditions for test cases.""" | ||
self.user, _ = User.objects.get_or_create( | ||
username="10024578", | ||
username="1333666888", | ||
) | ||
self.certificate_data = CertificateData( | ||
user=UserData( | ||
|
@@ -84,6 +89,7 @@ def test_generate_certificate_data(self, generate_certificate_mock, passing_mock | |
|
||
expected_value = { | ||
"id": certificate.id, | ||
'reference_id': '1333666888~course-v1:test+Cx105+2022_T4', | ||
"created_at": str(time.date()), | ||
"expiration_date": None, | ||
"grade": self.certificate_data.grade * 100, | ||
|
@@ -120,9 +126,131 @@ def test_invalid_group_codes(self, generate_certificate_mock, passing_mock): | |
certificate.id = 85 | ||
generate_certificate_mock.objects.get.return_value = certificate | ||
passing_mock.return_value = True | ||
data = { | ||
external_certificate_data = { | ||
"time": timezone.now(), | ||
"certificate_data": self.certificate_data, | ||
} | ||
|
||
self.assertRaises(KeyError, _generate_external_certificate_data, **data) | ||
self.assertRaises(KeyError, _generate_external_certificate_data, **external_certificate_data) | ||
|
||
@override_settings(EXTERNAL_CERTIFICATES_GROUP_CODES={"course-v1:test+Cx105+2022_T4": "ABC123"}) | ||
@patch("eox_nelp.signals.utils._user_has_passing_grade") | ||
@patch("eox_nelp.signals.utils.GeneratedCertificate") | ||
@data(*WRONG_NATIONAL_IDS) | ||
def test_invalid_mational_id(self, wrong_national_id, generate_certificate_mock, passing_mock): | ||
"""This tests when the user has an invalid NationalId. | ||
Expected behavior: | ||
- Raise ValueError | ||
""" | ||
certificate = Mock() | ||
certificate.id = 85 | ||
generate_certificate_mock.objects.get.return_value = certificate | ||
passing_mock.return_value = True | ||
wrong_user, _ = User.objects.get_or_create( | ||
username=wrong_national_id, | ||
) | ||
certificate_data = CertificateData( | ||
user=UserData( | ||
pii=UserPersonalData( | ||
username=wrong_user.username, | ||
email="[email protected]", | ||
name="Harry Potter", | ||
), | ||
id=wrong_user.id, | ||
is_active=True, | ||
), | ||
course=CourseData( | ||
course_key=CourseKey.from_string("course-v1:test+Cx105+2022_T4"), | ||
), | ||
mode="audit", | ||
grade=0.85, | ||
current_status="non-passing", | ||
download_url="", | ||
name="", | ||
) | ||
external_certificate_data = { | ||
"time": timezone.now(), | ||
"certificate_data": certificate_data, | ||
} | ||
|
||
self.assertRaisesRegex( | ||
ValueError, | ||
f"The username or national_id: {wrong_user.username} doesnt match national ID regex", | ||
_generate_external_certificate_data, | ||
**external_certificate_data, | ||
) | ||
|
||
@override_settings(EXTERNAL_CERTIFICATES_GROUP_CODES={"course-v1:test+Cx105+2022_T4": "ABC123"}) | ||
@patch("eox_nelp.signals.utils._user_has_passing_grade") | ||
@patch("eox_nelp.signals.utils.GeneratedCertificate") | ||
@data(*SAML_EXTRA_ASSOCIATIONS_LIST) | ||
def test_generate_certificate_data_saml_extra_association( | ||
self, | ||
saml_extra_association, | ||
generate_certificate_mock, | ||
passing_mock | ||
): | ||
"""This tests the normal behavior ofa user with saml_extra_association | ||
the method `_generate_external_certificate_data` | ||
Expected behavior: | ||
- Result is as the expected value | ||
- GeneratedCertificate mock is called with the right parameters. | ||
- _user_has_passing_grade is called with the right parameters. | ||
""" | ||
time = timezone.now() | ||
certificate = Mock() | ||
certificate.id = 99 | ||
generate_certificate_mock.objects.get.return_value = certificate | ||
passing_mock.return_value = True | ||
saml_association_user, _ = User.objects.get_or_create( | ||
username=saml_extra_association, | ||
) | ||
certificate_data = CertificateData( | ||
user=UserData( | ||
pii=UserPersonalData( | ||
username=saml_association_user.username, | ||
email="[email protected]", | ||
name="Harry Potter", | ||
), | ||
id=saml_association_user.id, | ||
is_active=True, | ||
), | ||
course=CourseData( | ||
course_key=CourseKey.from_string("course-v1:test+Cx105+2022_T4"), | ||
), | ||
mode="audit", | ||
grade=0.88, | ||
current_status="non-passing", | ||
download_url="", | ||
name="", | ||
) | ||
national_id = saml_association_user.username[:10] | ||
|
||
expected_value = { | ||
"id": certificate.id, | ||
'reference_id': f'{national_id}~course-v1:test+Cx105+2022_T4', | ||
"created_at": str(time.date()), | ||
"expiration_date": None, | ||
"grade": certificate_data.grade * 100, | ||
"is_passing": True, | ||
"group_code": settings.EXTERNAL_CERTIFICATES_GROUP_CODES[str(self.certificate_data.course.course_key)], | ||
"user": { | ||
"national_id": national_id, | ||
"english_name": certificate_data.user.pii.name, | ||
"arabic_name": "", | ||
} | ||
} | ||
|
||
result = _generate_external_certificate_data(time, certificate_data) | ||
|
||
self.assertEqual(result, expected_value) | ||
generate_certificate_mock.objects.get.assert_called_once_with( | ||
user=saml_association_user, | ||
course_id=certificate_data.course.course_key, | ||
) | ||
passing_mock.assert_called_once_with( | ||
saml_association_user, | ||
str(certificate_data.course.course_key) | ||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters