chore: rename not_passing

eduNEXT · Sep 12, 2023 · f398520 · f398520
1 parent 732df1d
commit f398520
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 22 deletions.
diff --git a/eox_nelp/stats/api/v1/views.py b/eox_nelp/stats/api/v1/views.py
@@ -110,7 +110,7 @@ class GeneralCourseStatsView(APIView):
                     "professional": {},
                     "no-id-professional": {
                         "downloadable": 5,
-                        "not_passing": 4,
+                        "notpassing": 4,
                     },
                     "masters": {},
                     "executive-education": {},
@@ -149,7 +149,7 @@ class GeneralCourseStatsView(APIView):
             "professional": {},
             "no-id-professional": {
                 "downloadable": 5,
-                "not_passing": 4...
+                "notpassing": 4...
             },
             "masters": {...},
             "executive-education": {...},

diff --git a/eox_nelp/stats/metrics.py b/eox_nelp/stats/metrics.py
@@ -158,7 +158,7 @@ def get_course_certificates_metric(course_key):
                 "professional": {...},
                 "no-id-professional": {
                     "downloadable": 5,
-                    "not_passing": 4,
+                    "notpassing": 4,
                 },
                 "masters": {...},
                 "executive-education": {...}

diff --git a/eox_nelp/stats/tests/api/v1/tests_views.py b/eox_nelp/stats/tests/api/v1/tests_views.py
@@ -104,15 +104,15 @@ def test_total_certificates(self, mock_metrics):
         total_courses = 4
         fake_metric = {
             "certificates": {
-                "verified": {"downloadable": 0, "not_passing": 0},
-                "honor": {"downloadable": 0, "not_passing": 0},
-                "audit": {"downloadable": 0, "not_passing": 0},
-                "professional": {"downloadable": 0, "not_passing": 0},
-                "no-id-professional": {"downloadable": 5, "not_passing": 4},
-                "masters": {"downloadable": 0, "not_passing": 0},
-                "executive-education": {"downloadable": 0, "not_passing": 0},
-                "paid-executive-education": {"downloadable": 0, "not_passing": 0},
-                "paid-bootcamp": {"downloadable": 0, "not_passing": 0},
+                "verified": {"downloadable": 0, "notpassing": 0},
+                "honor": {"downloadable": 0, "notpassing": 0},
+                "audit": {"downloadable": 0, "notpassing": 0},
+                "professional": {"downloadable": 0, "notpassing": 0},
+                "no-id-professional": {"downloadable": 5, "notpassing": 4},
+                "masters": {"downloadable": 0, "notpassing": 0},
+                "executive-education": {"downloadable": 0, "notpassing": 0},
+                "paid-executive-education": {"downloadable": 0, "notpassing": 0},
+                "paid-bootcamp": {"downloadable": 0, "notpassing": 0},
                 "total": 9,
             }
         }

diff --git a/eox_nelp/stats/tests/tests_metrics.py b/eox_nelp/stats/tests/tests_metrics.py
@@ -293,7 +293,7 @@ def setUp(self):  # pylint: disable=invalid-name
             'grade': '59.0',
             'key': '807e31d92ab6aeaab514d7669bb2b014',
             'distinction': False,
-            'status': 'not_passing',
+            'status': 'notpassing',
             'mode': 'honor',
             'name': 'Ben Park',
             'error_reason': '',
@@ -414,39 +414,39 @@ def test_right_certificates_metric(self):
         cert_dict = {
             "verified": {
                 "downloadable": 0,
-                "not_passing": 0
+                "notpassing": 0
             },
             "honor": {
                 "downloadable": 0,
-                "not_passing": 1,
+                "notpassing": 1,
             },
             "audit": {
                 "downloadable": 0,
-                "not_passing": 0
+                "notpassing": 0
             },
             "professional": {
                 "downloadable": 0,
-                "not_passing": 0
+                "notpassing": 0
             },
             "no-id-professional": {
                 "downloadable": 1,
-                "not_passing": 0
+                "notpassing": 0
             },
             "masters": {
                 "downloadable": 0,
-                "not_passing": 0
+                "notpassing": 0
             },
             "executive-education": {
                 "downloadable": 0,
-                "not_passing": 0
+                "notpassing": 0
             },
             "paid-executive-education": {
                 "downloadable": 0,
-                "not_passing": 0
+                "notpassing": 0
             },
             "paid-bootcamp": {
                 "downloadable": 0,
-                "not_passing": 0
+                "notpassing": 0
             },
             "total": 2
         }