refactor: implement abstract backend class #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanseto
reviewed
Jul 4, 2024
| class ErrorRealTimeImportHandler(AbstractBackend): | ||
| """Class for managing validation error pipe executing the pipeline for data validation.""" | ||
|
|
||
| def handle_error(self, exception, failed_step_pipeline): |
There was a problem hiding this comment.
I think this could be removed.
In this case is doing nothing... or maybe we're gonna manage the error in the error pipeline?
This PR is changing because in the past the error pipeline could fail and call again the error pipeline...
There was a problem hiding this comment.
nop, this is necessary since the parent class is an abstract class , so all methods defined as abstract methods have to be implemented in the subclasses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor that implements a backend abstract class, basivally this moves the handler error logic to a new method that could be overridden by any subclass
Testing instructions
Before
After
Additional information
Include anything else that will help reviewers and consumers understand the change.
Checklist for Merge