Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: sms vendor with notification-gateway api #191

Merged
merged 2 commits into from
Jul 16, 2024
Merged

refactor: sms vendor with notification-gateway api #191

merged 2 commits into from
Jul 16, 2024

Conversation

johanseto
Copy link
Collaborator

@johanseto johanseto commented Jul 8, 2024 •
edited
Loading

Description

refactor: sms vendor with notification-gateway api

Testing instructions

  • Use your local cli.
  • Set credentials in settings, and init one SMSVendorApiClient
  • Send an sms to a recipient you know.
  • Check your phone if you received the msg.
    2024-07-05_18-55

After

Additional information

Include anything else that will help reviewers and consumers understand the change.

  • Does this change depend on other changes elsewhere?
  • Any special concerns or limitations? For example: deprecations, migrations, security, or accessibility.
  • Link to other information about the change, such as Jira issues, GitHub issues, or Discourse discussions.

Checklist for Merge

  • Tested in a remote environment
  • Updated documentation
  • Rebased master/main
  • Squashed commits

@johanseto johanseto self-assigned this Jul 8, 2024
@johanseto johanseto marked this pull request as ready for review July 8, 2024 17:05
@andrey-canon
Copy link
Collaborator

please share the test credentials privately

@johanseto
Copy link
Collaborator Author

please share the test credentials privately

I already share them with u

andrey-canon
andrey-canon approved these changes Jul 16, 2024
View reviewed changes
Copy link
Collaborator

@andrey-canon andrey-canon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johanseto johanseto merged commit 1973b74 into master Jul 16, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrey-canon andrey-canon andrey-canon approved these changes

Assignees

@johanseto johanseto

Labels
size/s test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johanseto @andrey-canon