refactor: replace generic list create api view with generic viewset a… #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanseto
approved these changes
Jul 16, 2024
There was a problem hiding this comment.
Wroking as expected. The only thing is the is necessary eh fix of https://github.com/eduNEXT/eox-nelp/pull/201/commits
| return Response({}, status=status.HTTP_200_OK, headers=headers) | ||
| response = super().create(request, *args, **kwargs) | ||
|
|
||
| if response.status_code == status.HTTP_201_CREATED: |
There was a problem hiding this comment.
This is so crazy, chaging normal status codes. But we depends on client logic 201 ->200
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This doesn't modify anything; it simply changes the current implementation to use a viewset implementation and updates the create method to utilize the super method instead of duplicating it.