Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change candidate representation from id to username #202

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

andrey-canon
Copy link
Collaborator

@andrey-canon andrey-canon commented Jul 15, 2024

Description

This changes the candidate representation from id to username

Before

image

After

image

Additional information

Include anything else that will help reviewers and consumers understand the change.

  • Does this change depend on other changes elsewhere?
  • Any special concerns or limitations? For example: deprecations, migrations, security, or accessibility.
  • Link to other information about the change, such as Jira issues, GitHub issues, or Discourse discussions.

Checklist for Merge

  • Tested in a remote environment
  • Updated documentation
  • Rebased master/main
  • Squashed commits

Copy link
Collaborator

@johanseto johanseto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected.
image

@andrey-canon andrey-canon force-pushed the and/fix_result_notification_backend branch from bad261a to 3036716 Compare July 16, 2024 22:42
@andrey-canon andrey-canon changed the base branch from and/fix_result_notification_backend to master July 16, 2024 22:46
@andrey-canon andrey-canon force-pushed the and/change_candidate_representation branch from 98bb029 to fc79f4e Compare July 16, 2024 22:47
@andrey-canon andrey-canon merged commit 1d75e01 into master Jul 16, 2024
6 of 7 checks passed
@andrey-canon andrey-canon deleted the and/change_candidate_representation branch July 16, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants