feat: add filter backends and limit the list view to super or staff u… #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanseto
reviewed
Jul 16, 2024
| Raises: | ||
| Http404: If the user does not have the necessary permissions. | ||
| """ | ||
| if request.user.is_superuser or request.user.is_staff: |
There was a problem hiding this comment.
So this force that the User used for the application to get the token, needs to be staff?
I think that only creating the application was enough to get a token and use the API.
There was a problem hiding this comment.
if you are not staff you shouldn't be able to get data from another users
andrey-canon
force-pushed
the
and/change_candidate_representation
branch
from
98bb029
to
fc79f4e
Compare
andrey-canon
changed the base branch from
and/change_candidate_representation
to
master
andrey-canon
force-pushed
the
and/add_filter_and_staff_condition
branch
from
2cdf9af
to
8522875
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change Objective:
Enhance endpoint security and functionality by limiting access to authorized users.
Facilitate event searches by user and course using the SearchFilter.
Testing instructions
/eox-nelp/api/pearson_vue/v1/resultNotification/with a staff or super user, expected behavior => list of records returned/eox-nelp/api/pearson_vue/v1/resultNotification/with a non staff , expected behavior => 404/eox-nelp/api/pearson_vue/v1/resultNotification/?search=course-v1:edx%2BCS101%2B2023_t4or/eox-nelp/api/pearson_vue/v1/resultNotification/?search=<username>expected behavior => filtered list of records