Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: raise exception on api response error #215

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

andrey-canon
Copy link
Collaborator

@andrey-canon andrey-canon commented Aug 14, 2024

Description

Raise an exception to enable the fail case on eox-audit-mode when the response contains an error, this also limits the retry scenario to Timeout or connection error

Useful information to include:

  • Include screenshots for changes to the UI (ideally, both "before" and "after" screenshots, if applicable).
  • Provide links to the description of corresponding configuration changes. Remember to correctly annotate these
    changes.

Testing instructions

Before

image

After

image

@github-actions github-actions bot added the test label Aug 14, 2024
@johanseto johanseto self-assigned this Aug 14, 2024
@johanseto johanseto self-requested a review August 14, 2024 22:02
Copy link
Collaborator

@johanseto johanseto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrey-canon andrey-canon merged commit ca5ab52 into master Aug 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants