Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jlc/add common plugin tests #42

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Jlc/add common plugin tests #42

wants to merge 1 commit into from

Conversation

johanseto
Copy link
Collaborator

Description

This PR has two principal functions.

  • Configure the frame or template for check due dates command and celery task import for add logic.
  • Add test: for the celery import and COMMON_SETTINGS_PLUGINS TEST
    Useful information to include:
  • Increase coverage to 94

Checklist for Merge

  • Tested in a remote environment
  • Updated documentation
  • Rebased master/main
  • Squashed commits

@johanseto johanseto self-assigned this Apr 17, 2023
@github-actions github-actions bot added the size/m m lines label label Apr 17, 2023
@johanseto johanseto force-pushed the jlc/course-due-date-command-celery-config branch from ff081b7 to df9cf0b Compare April 17, 2023 18:32
andrey-canon
andrey-canon reviewed Apr 17, 2023
View reviewed changes
Copy link
Collaborator

@andrey-canon andrey-canon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you split this in two different PRs, celery task and command and could you do a rebase over the branch https://github.com/eduNEXT/eox-nelp/tree/and/add_notifications_models to start with the implementation?

eox_nelp/settings/common.py Outdated
settings.INSTALLED_APPS.append(COURSE_CREATOR_APP)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably this will be no necessary

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are meaning the white line?
image

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whole block

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it fails me if I do not register the task(in the worker). At the moment the notifications task file is not called or imported in a principal file. So celery couldn't start a not registered task.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's why I said that probably this is not necessary, for reference check this PR I didn't need this

@johanseto johanseto changed the title Jlc/course due date command celery config Jlc/course due date task celery config Apr 17, 2023
@github-actions github-actions bot removed the commands label Apr 17, 2023
@johanseto johanseto changed the title Jlc/course due date task celery config Jlc/course due date task creation and common tests Apr 19, 2023
@johanseto johanseto changed the title Jlc/course due date task creation and common tests Jlc/course due date task creation and common plugin tests Apr 19, 2023
@johanseto johanseto force-pushed the jlc/course-due-date-command-celery-config branch from d95402c to 539c8a9 Compare April 19, 2023 15:55
@github-actions github-actions bot added size/s and removed size/m m lines label labels Apr 19, 2023
@johanseto johanseto changed the title Jlc/course due date task creation and common plugin tests Jlc/add common plugin tests Apr 19, 2023
@johanseto johanseto force-pushed the jlc/course-due-date-command-celery-config branch from 539c8a9 to ba3dd23 Compare April 19, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrey-canon andrey-canon Awaiting requested review from andrey-canon

Assignees

@johanseto johanseto

Labels
size/s test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johanseto @andrey-canon