-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
And jlc/add essentials views #54
Conversation
This PR exceeds the recommended size of 1000 lines. Check if you are NOT addressing multiple issues with one PR. If is not the case continue the review process. |
e0886f7
to
d3cfac0
Compare
This PR exceeds the recommended size of 1000 lines. Check if you are NOT addressing multiple issues with one PR. If is not the case continue the review process. |
1 similar comment
This PR exceeds the recommended size of 1000 lines. Check if you are NOT addressing multiple issues with one PR. If is not the case continue the review process. |
eox_nelp/course_experience/frontend/src/components/FeedbackCarousel/index.scss
Outdated
Show resolved
Hide resolved
@@ -0,0 +1,21 @@ | |||
"""Frontend Views V1 file. | |||
|
|||
Contains all the views for the first version of the procedures. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
procedures ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR exceeds the recommended size of 1000 lines. Check if you are NOT addressing multiple issues with one PR. If is not the case continue the review process. |
@andrey-canon this one manages a little the styles for the title. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please squash commits
This PR exceeds the recommended size of 1000 lines. Check if you are NOT addressing multiple issues with one PR. If is not the case continue the review process. |
@andrey-canon what do you think of this last commit. |
feat: Add basic frontend configuration fix: move to frontend folder feat: first approx to xp frontend templates fix: extract static folder from course experience fix: render react basic component feat: set environment and add report button feat: add feedback carousel component in template feat: add styles from learning mfe of stage This styles were built by learning mfe. This includes paragon vars that allow give more beauty approach to the component. feat: add paragon styles refactor: move main view to feedback courses view feat: generate final js file by using frontend-build chore: remove unused dependencies and add missing dependency feat: add templates files config feat: add backend for edxmako style: pass isort and pytest feat: change url for frontend courses test: add unittest for edxmako templates This is for course experience feedback templates. feat: add template render extra test style: add docstrings for tests feat: add hash to webpack built to uncache CDN Revert "feat: add hash to webpack built to uncache CDN" This reverts commit cd789c2. fix: remove extra typo ; rendered in the component chore: pr feedback improve docstring feat: remove unnecessary pasted styles feat: add custom styles to manage feedback title feat: unset background color for body
2ad7287
to
ced74ad
Compare
This PR exceeds the recommended size of 1000 lines. Check if you are NOT addressing multiple issues with one PR. If is not the case continue the review process. |
Description
Add a view to show templates that use react components.
Testing instructions
Clone this repo and go to the URL:
/
eox-nelp/frontend/experience/feedback/courses/
After
The static are files transformed(hashed) by the openedx lms static.
Additional information
Deployed in stage
Jira stories:
https://edunext.atlassian.net/browse/FUTUREX-422
Checklist for Merge