Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

And jlc/add essentials views #54

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Conversation

johanseto
Copy link
Collaborator

@johanseto johanseto commented Jun 26, 2023

Description

Add a view to show templates that use react components.

  • Configuration to use npm and frontend essentials to the component.
  • feedback carrousel react component using frontend essentials.
  • Configuration to add templates to the platform using eox-nelp.
  • feedback course carrousel view based on template.

Testing instructions

Clone this repo and go to the URL:
/eox-nelp/frontend/experience/feedback/courses/

After

Peek 2023-06-26 15-48

The static are files transformed(hashed) by the openedx lms static.
2023-06-27_16-13

Additional information

Deployed in stage
Jira stories:
https://edunext.atlassian.net/browse/FUTUREX-422

Checklist for Merge

  • Tested in a remote environment
  • Updated documentation
  • Rebased master/main
  • Squashed commits

@github-actions
Copy link

This PR exceeds the recommended size of 1000 lines. Check if you are NOT addressing multiple issues with one PR. If is not the case continue the review process.

@johanseto johanseto self-assigned this Jun 26, 2023
@johanseto johanseto force-pushed the and-jlc/add_essentials_views branch from e0886f7 to d3cfac0 Compare June 27, 2023 16:02
@github-actions
Copy link

This PR exceeds the recommended size of 1000 lines. Check if you are NOT addressing multiple issues with one PR. If is not the case continue the review process.

1 similar comment
@github-actions
Copy link

This PR exceeds the recommended size of 1000 lines. Check if you are NOT addressing multiple issues with one PR. If is not the case continue the review process.

@@ -0,0 +1,21 @@
"""Frontend Views V1 file.

Contains all the views for the first version of the procedures.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

procedures ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions
Copy link

This PR exceeds the recommended size of 1000 lines. Check if you are NOT addressing multiple issues with one PR. If is not the case continue the review process.

@johanseto
Copy link
Collaborator Author

@andrey-canon this one manages a little the styles for the title.
31e8bf2
Screenshot from 2023-06-28 10-31-46

Copy link
Collaborator

@andrey-canon andrey-canon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please squash commits

@github-actions
Copy link

This PR exceeds the recommended size of 1000 lines. Check if you are NOT addressing multiple issues with one PR. If is not the case continue the review process.

@johanseto
Copy link
Collaborator Author

@andrey-canon what do you think of this last commit.
ad7287
image

feat: Add basic frontend configuration

fix: move to frontend folder

feat: first approx to xp frontend templates

fix: extract static folder from course experience

fix: render react basic component

feat: set environment and add report button

feat: add feedback carousel component in template

feat: add styles from learning mfe of stage

This styles were built by learning mfe.
This includes paragon vars that allow give more beauty approach to the component.

feat: add paragon styles

refactor: move main view to feedback courses view

feat: generate final js file by using frontend-build

chore: remove unused dependencies and add missing dependency

feat: add templates files config

feat: add backend for edxmako

style: pass isort and pytest

feat: change url for frontend courses

test: add unittest for edxmako templates

This is for course experience feedback templates.

feat: add template render extra test

style: add docstrings for tests

feat: add hash to webpack built to uncache CDN

Revert "feat: add hash to webpack built to uncache CDN"

This reverts commit cd789c2.

fix: remove extra typo ; rendered in the component

chore: pr feedback improve docstring

feat: remove unnecessary pasted styles

feat: add custom styles to manage feedback title

feat: unset background color for body
@johanseto johanseto force-pushed the and-jlc/add_essentials_views branch from 2ad7287 to ced74ad Compare June 28, 2023 19:11
@github-actions
Copy link

This PR exceeds the recommended size of 1000 lines. Check if you are NOT addressing multiple issues with one PR. If is not the case continue the review process.

@johanseto johanseto merged commit 526cf2d into master Jun 28, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants