feat: add extra fields options to relationships #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrey-canon
reviewed
Jul 7, 2023
andrey-canon
approved these changes
Jul 7, 2023
johanseto
force-pushed
the
jlc/add-relations-extra-field
branch
from
fc078eb
to
9637e2d
Compare
This change is applied to course-experience api. The relations file inherit from json api relation but add the possibility to add some extra fields using a function. The function has to be passed through the new relation using `get_extra_fields` kwarg. There you can calculate a dict that would be added to corresponding relationhips field. The base json api only add id and type, with this change you cad add extra model attributes. https://github.com/django-json-api/django-rest-framework-json-api/blob/main/rest_framework_json_api/relations.py#L255 chore: pr suggestions Co-authored-by: Andrey Cañon <[email protected]>
johanseto
force-pushed
the
jlc/add-relations-extra-field
branch
from
9637e2d
to
a345957
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change is applied to course-experience api.
The relations file inherit from json api relation but add the possibility to add some extra fields using a function. The function has to be passed through the new relation using
get_extra_fieldskwarg. There you can calculate a dict that would be added to corresponding relationhips field. The base json api only addidandtype, with this change you cad add extra model attributes.https://github.com/django-json-api/django-rest-framework-json-api/blob/main/rest_framework_json_api/relations.py#L255
Testing instructions
Clone the repo and check anything is broken and the feedback API work with it same functionality.
After
Additional information
jira story:
https://edunext.atlassian.net/jira/software/c/projects/FUTUREX/boards/36?modal=detail&selectedIssue=FUTUREX-459
Checklist for Merge