refactor: implementing abstract API class #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanseto
reviewed
Aug 2, 2023
| Classes: | ||
| LikeDislikeUnitExperienceTestCase: Test LikeDislikeUnitExperienceView. |
| ]) | ||
| def setUp(self): | ||
| """Setup common conditions for every test case""" | ||
| self.api_class = FuturexApiClient |
There was a problem hiding this comment.
These lines could be?
api_client = self.api_class()| return {} | ||
| @property | ||
| def base_url(self): | ||
| return getattr(settings, "FUTUREX_API_URL") |
There was a problem hiding this comment.
This needs default value?
There was a problem hiding this comment.
No, since in the past the decision was if someone wants to use it they must set up everything otherwise this would raise an exception
eox_nelp/api_clients/__init__.py
Outdated
| response.status_code, | ||
| ) | ||
|
|
||
| return {} |
There was a problem hiding this comment.
I know this is a refactor, but here you could a message of error or something related to the response...
How can I know if it is a 200 empty or an error? By the way, is the opportunity to handle it or maybe in the future because is working with that way now.
andrey-canon
force-pushed
the
and/refactor_futurex_api_client
branch
from
dc04f28
to
b8b3f65
Compare
johanseto
approved these changes
Aug 2, 2023
This move the general logic from the FuturexAPIClient to a new Abstract class.
andrey-canon
force-pushed
the
and/refactor_futurex_api_client
branch
from
b8b3f65
to
a672ded
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This move the general logic from the FuturexAPIClient to a new Abstract class.