feat: adding extra headers feature. #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrey-canon
force-pushed
the
and/add_course_mapping
branch
from
eaede21
to
7fa6d3d
Compare
andrey-canon
force-pushed
the
and/add_extra_headers
branch
from
088ff4c
to
2b9c288
Compare
This allows to include header from the django settings in the api _client session https://edunext.atlassian.net/browse/FUTUREX-490
andrey-canon
force-pushed
the
and/add_extra_headers
branch
from
2b9c288
to
e39e580
Compare
johanseto
approved these changes
Aug 8, 2023
| @@ -27,7 +28,7 @@ def test_enrollment_progress(self, auth_mock, post_mock): | |||
| - Response is the expected value | |||
| - make_post was called with the right values. | |||
| """ | |||
| auth_mock.return_value = {} | |||
| auth_mock.return_value = requests.Session() | |||
There was a problem hiding this comment.
Why the use of extra_headers_key. Needs the change of the empty dict to request.Session()
There was a problem hiding this comment.
This should have been modified in the previous refactor since the _authenticate method returns a Session instead of a dict
johanseto
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This allows to include header from the django settings in the api _client session https://edunext.atlassian.net/browse/FUTUREX-490