feat: add prefix to reference_id parameter in certificate api client #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanseto
approved these changes
Aug 10, 2023
eox_nelp/api_clients/certificates.py
Outdated
| @@ -49,7 +49,7 @@ def create_external_certificate(self, certificate_data): | |||
| path = "Certificates" | |||
| user = certificate_data["user"] | |||
| payload = { | |||
| "reference_id": certificate_data["id"], | |||
| "reference_id": f"openedx-lms-cert-{certificate_data['id']}", | |||
There was a problem hiding this comment.
I think that they could have an edx integration. Is something related futurex or nelp. Or just with the open is different from edx. Also to remind the possibility of the existence of other openedx integration...?
There was a problem hiding this comment.
IMO the probability of that is almost null and probably when they have another integration you will have another job, but anyway I have already applied that
johanseto
approved these changes
Aug 10, 2023
andrey-canon
force-pushed
the
and/add_prefix_to_reference
branch
from
7f0fb34
to
10f9dac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a prefix to the payload reference id parameter, I didn't include the host since I consider that information is not relevant because the certificate is not associated with a tenant, that is associated with a course and a course could be associated with multiple tenants