feat: allows to audit the create_external_certificates method #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrey-canon
force-pushed
the
and/audit_certificates_api_client
branch
from
143eeea
to
b617c3a
Compare
johanseto
reviewed
Aug 10, 2023
requirements/base.in
Outdated
| @@ -9,6 +9,7 @@ djangorestframework-jsonapi==5.0.0 | |||
| edx-drf-extensions | |||
| edx-i18n-tools | |||
| edx-opaque-keys | |||
| eox-audit-model | |||
There was a problem hiding this comment.
So you prefer eox-audit now is mandatory to the plugin?
There was a problem hiding this comment.
I didn't consider that dependency was optional, I thought the current implementation was designed in that way due to the tests, probably in the future this should be mandatory since this is a plugin designed for NELC and doesn't make sense to make that optional for other installations when we only have one however that should be applied in another pr
| "value": certificate_data["grade"], | ||
| "type": "percentage" | ||
| }, | ||
| "metadata": getattr(settings, "EXTERNAL_CERTIFICATES_METADATA", {}), |
There was a problem hiding this comment.
These settings are general settings. Not a tenant aware.
There was a problem hiding this comment.
settings are settings tenant awareness depends on eox-tenant
andrey-canon
force-pushed
the
and/audit_certificates_api_client
branch
from
9eb9057
to
818ad0b
Compare
andrey-canon
force-pushed
the
and/add_prefix_to_reference
branch
from
7f0fb34
to
10f9dac
Compare
andrey-canon
changed the base branch from
and/add_prefix_to_reference
to
master
andrey-canon
force-pushed
the
and/audit_certificates_api_client
branch
from
818ad0b
to
ede72cb
Compare
johanseto
approved these changes
Aug 10, 2023
andrey-canon
force-pushed
the
and/audit_certificates_api_client
branch
from
ede72cb
to
797c944
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This allows to audit the
create_external_certificatemethodTesting instructions
1.Set external certificates feature
2. Save a GeneratedCertificate in the admin panel
3. check /admin/eox_audit_model/auditmodel/ table