feat: adding enrollment receiver #91
Conversation
| the beginning of the course, then the certificate receiver will update the grade. | ||
|
|
||
| Args: | ||
| instance<CourseEnrollment>: This an instance of the model CourseEnrollment. |
There was a problem hiding this comment.
Hey Here I have some doubt in some signal we uses instance in other the name of the instance.
https://github.com/eduNEXT/eox-nelp/pull/91/files#diff-51a002e5f9d204c9c4fb523f904e54043838095b1a1a2b498d768d5f2d09cb43R70
So instead of instance is not easier course_enrollment ?
There was a problem hiding this comment.
that names depends on how the signal is emitted
| ) | ||
|
|
||
| create_external_certificate.delay( | ||
| external_certificate_data=_generate_external_certificate_data( |
There was a problem hiding this comment.
Here I found a problem if I create an enrollment from scratch.
Maybe the certificate doesn't exist and resolves
with 500.
There was a problem hiding this comment.
Good catch, the good new is that you found a line that is not necessary
| - create_external_certificate is called with the _generate_external_certificate_data output. | ||
| - Info was logged. | ||
| """ | ||
| generate_data_mock.return_value = { |
There was a problem hiding this comment.
Also as above, this is mocked so t when this doesn't exist the process turns into an error.
andrey-canon
force-pushed
the
and/notify_enrollment
branch
from
c8422aa
to
9c77283
Compare
eox_nelp/signals/tests/test_utils.py
Outdated
| @data(*WRONG_NATIONAL_IDS) | ||
| def test_invalid_mational_id(self, wrong_national_id, generate_certificate_mock, passing_mock): | ||
| def test_invalid_mational_id(self, wrong_national_id, passing_mock): |
There was a problem hiding this comment.
| def test_invalid_mational_id(self, wrong_national_id, passing_mock): | |
| def test_invalid_national_id(self, wrong_national_id, passing_mock): |
This will create external certificates when a user enrolls in a course, generally that certificate will have a grade of 0 and then that will be updated by the certificate_publisher https://edunext.atlassian.net/browse/FUTUREX-488
andrey-canon
force-pushed
the
and/notify_enrollment
branch
from
207561b
to
8e3a54a
Compare
Description
This will create external certificates when a user enrolls in a course, generally that certificate will have a grade of 0 and then that will be updated by the certificate_publisher
https://edunext.atlassian.net/browse/FUTUREX-488
Testing instructions