Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add certificates stats #97

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Conversation

andrey-canon
Copy link
Collaborator

Description

This updates frontend essentials to include the new certificates metric https://edunext.atlassian.net/browse/FUTUREX-489

Testing instructions

Just go to /eox-nelp/stats/tenant/ and include the show_certificates query param if you want to hide the metric

includes the CERTIFICATE_IMAGE_URL setting into the STATS_SETTINGS to modify the logo image

Results

image

Copy link
Collaborator

@johanseto johanseto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Working with the desired behavior.
Peek 2023-09-14 16-06

package.json Outdated
@@ -15,7 +15,7 @@
"license": "ISC",
"homepage": "https://bitbucket.org/edunext/eox-nelp#readme",
"dependencies": {
"@edunext/frontend-essentials": "^1.6.1",
"@edunext/frontend-essentials": "^1.7.0-rc",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will be updated after all process is completed. I mean essentials bump?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

This updates frontend essentials to include the new certificates metric
https://edunext.atlassian.net/browse/FUTUREX-489
@andrey-canon andrey-canon merged commit 13ed2ff into master Sep 14, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants