perf: sumac release support #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magajh
requested changes
Dec 20, 2024
There was a problem hiding this comment.
@luisfelipec95 thanks, just a couple of comments:
- Please review chore(deps): bump pypa/gh-action-pypi-publish from 1.12.2 to 1.12.3 #123
- Since we are removing support for python 3.8, I believe this constraint is no longer needed https://github.com/eduNEXT/eox-tagging/blob/master/requirements/constraints.txt#L15-L16, so we'll need to remove it and update requirements
- We need to update the classifiers in the setup file https://github.com/eduNEXT/eox-tagging/blob/master/setup.py#L80
|
@luisfelipec95 why are we removing support for python 3.8 here? where you getting problems when trying to upgrade the requirements? |
@magajh https://github.com/eduNEXT/eox-tagging/actions/runs/12421325902/job/34680763565 |
magajh
approved these changes
Dec 20, 2024
|
@luisfelipec95 have we tested this in stage yet? |
jignaciopm
approved these changes
Dec 27, 2024
There was a problem hiding this comment.
LGTM! @luisfelipec95 @magajh i tested this in stage and all it great!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to support the new Sumac release and removes tests and constraints for Python 3.8 due to compatibility issues.
Testing instructions
1, Create a Sumac environment using Tutor or TVM.
2. Install eox-tagging using this branch you can follow the official tutor documentation.
3. Follow the test cases file.