Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: add Quince support DS-776 #196

Merged
merged 10 commits into from
Feb 27, 2024
Merged

perf: add Quince support DS-776 #196

merged 10 commits into from
Feb 27, 2024

Conversation

MaferMazu
Copy link
Contributor

@MaferMazu MaferMazu commented Feb 15, 2024

Description

This PR brings support to the Open edX Quince release.

  • Updated the GitHub actions.
  • Update the core and normal requirements.
  • Update the readme.
  • The test cases work.

Testing instructions

Follow the test case file: https://docs.google.com/document/d/1921hOajxAYrdin_thEZ005aQBwPNoj2zsbgkf3q1Mjc/edit?usp=sharing

Additional information

I added some changes to improve the code and follow the pycodestyle and the pylint rules.

Checklist for Merge

  • Updated documentation
  • Rebased master/main
  • Squashed commits

@github-actions github-actions bot added size/l and removed size/m labels Feb 21, 2024
@MaferMazu MaferMazu changed the title chore: update github workflows perf: add Quince support DS-763 Feb 21, 2024
@MaferMazu MaferMazu marked this pull request as ready for review February 21, 2024 23:55
@MaferMazu MaferMazu changed the title perf: add Quince support DS-763 perf: add Quince support DS-776 Feb 21, 2024
dcoa
dcoa previously approved these changes Feb 22, 2024
Copy link
Contributor

@dcoa dcoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

I test the multitenancy funtions and works

bra-i-am
bra-i-am previously approved these changes Feb 26, 2024
Copy link
Contributor

@bra-i-am bra-i-am left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected!

@Asespinel
Copy link
Contributor

I checked the multitenancy and the commands and everything is working.

Asespinel
Asespinel previously approved these changes Feb 26, 2024
@MaferMazu
Copy link
Contributor Author

I forgot to update the readme; I'll update it and merge this. Thanks for the reviews.

@MaferMazu MaferMazu dismissed stale reviews from dcoa, Asespinel, and bra-i-am via ce4a1da February 27, 2024 15:28
@MaferMazu
Copy link
Contributor Author

I also removed the --settings=production from the doc because that was the cause of the errors. The commands will take the settings of the env they are running.

@Asespinel
Copy link
Contributor

LGTM!

Copy link
Contributor

@bra-i-am bra-i-am left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to review the docs before, sorry about that

Approved!

@MaferMazu MaferMazu merged commit c42930b into master Feb 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants