-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: add Quince support DS-776 #196
Conversation
11e4289
to
48ec7c4
Compare
48ec7c4
to
236a893
Compare
28db71a
to
2beeb07
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
I test the multitenancy funtions and works
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working as expected!
I checked the multitenancy and the commands and everything is working. |
I forgot to update the readme; I'll update it and merge this. Thanks for the reviews. |
I also removed the --settings=production from the doc because that was the cause of the errors. The commands will take the settings of the env they are running. |
LGTM! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot to review the docs before, sorry about that
Approved!
Description
This PR brings support to the Open edX Quince release.
Testing instructions
Follow the test case file: https://docs.google.com/document/d/1921hOajxAYrdin_thEZ005aQBwPNoj2zsbgkf3q1Mjc/edit?usp=sharing
Additional information
I added some changes to improve the code and follow the pycodestyle and the pylint rules.
Checklist for Merge