feat!: dropping support for python 3.5 #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From this commit forward only python 3.8 would be supported. This was breaking installations in Palm
|
Bummer, this xblock is still running tests in circleci which we completely disconnected recently. I'll have to test in other ways. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
From this point forward only python 3.8 would be supported. This was breaking installations in Palm
This came up in the forums. https://discuss.openedx.org/t/upgrading-to-tutor-16-0-3-palm/10870.
Installing this xblock in a palm release resulted in errors.
Reviewers
After approval
Keep in mind that after the change have been approved we might still need to do somethings.