Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update readme usage information to indicate that some features are deprecated since olive #52

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jignaciopm
Copy link

Description

This PR contain a little update about usage information in README, to indicate that some features are deprecated since Open edX Olive.

Reviewers

  • who is the person reviewing this changes? @MaferMazu
  • perhaps more than one?

After approval

Keep in mind that after the change have been approved we might still need to do somethings.

  • Squash
  • Bumpversion (major/minor/patch)

@@ -36,6 +36,8 @@ Include the Flow Control component in the content unit you want to control acces
* Enter the problem locator ids (as many as required) to evaluate the condition.
* Select an action to apply when the condition is met.

⚠️ Since Open edX Olive some the features could fail because to changes in MFE integration UI.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
⚠️ Since Open edX Olive some the features could fail because to changes in MFE integration UI.
⚠️ Since the Open edX Olive release, some features could fail because of the integration of MFE.

And I suggest adding this message before the installation instructions. To make it quickly visible.

@MaferMazu
Copy link

Also, I would change the commit type. This changes only the doc, so I suggest using docs instead of chore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants