forked from openedx/frontend-app-learning
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(redwood): add css support and cdn compatibility #17
Merged
bra-i-am
merged 5 commits into
ednx-release/redwood.master
from
bc/redwood-css-variables-support
May 23, 2024
Merged
feat(redwood): add css support and cdn compatibility #17
bra-i-am
merged 5 commits into
ednx-release/redwood.master
from
bc/redwood-css-variables-support
May 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bra-i-am
changed the title
perf: add runtime theming support to redwood
feat(redwood): add css support and cdn compatibility
May 16, 2024
bra-i-am
force-pushed
the
bc/redwood-css-variables-support
branch
2 times, most recently
from
May 17, 2024 16:23
1195acd
to
e0f93fb
Compare
bra-i-am
force-pushed
the
bc/redwood-css-variables-support
branch
from
May 17, 2024 19:39
f0d990f
to
923483c
Compare
dcoa
force-pushed
the
bc/redwood-css-variables-support
branch
from
May 20, 2024 05:23
718f3f9
to
9909d17
Compare
dcoa
approved these changes
May 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you think you will not need more changes for frontend-platform, you can create the npm package and merge once that package is updated.
bra-i-am
added a commit
that referenced
this pull request
Jul 23, 2024
* perf: add runtime theming support to redwood * fix: outline collapsible icons * fix: solve issue with overlaid input element * refactor: add frontend-platform dep from npm * refactor: rename frontend-build github branch --------- Co-authored-by: Diana Catalina Olarte <[email protected]>
bra-i-am
added a commit
that referenced
this pull request
Jul 23, 2024
* perf: add runtime theming support to redwood * fix: outline collapsible icons * fix: solve issue with overlaid input element * refactor: add frontend-platform dep from npm * refactor: rename frontend-build github branch --------- Co-authored-by: Diana Catalina Olarte <[email protected]>
bra-i-am
added a commit
that referenced
this pull request
Jul 29, 2024
* feat: [FC-0056] courseware sidebar enhancement (openedx#1398) - Display section and sequence progress - Add tracking event to the unit button - Hide the horizontal unit navigation with enabled sidebar navigation * fix: optimize scroll position observer after video fullscreen exit (openedx#1405) * feat!: organize plugin slots as components, add footer slot (openedx#1408) BREAKING CHANGE: slot ids have been changed for consistency * `sequence_container_plugin` -> `sequence_container_slot` * `unit_title_plugin` -> `unit_title_slot` Co-authored-by: Brian Smith <[email protected]> * feat(redwood): add css support and cdn compatibility (#17) * perf: add runtime theming support to redwood * fix: outline collapsible icons * fix: solve issue with overlaid input element * refactor: add frontend-platform dep from npm * refactor: rename frontend-build github branch --------- Co-authored-by: Diana Catalina Olarte <[email protected]> * fix: some variables weren't css-variables * fix: recreate package-lock --------- Co-authored-by: Ihor Romaniuk <[email protected]> Co-authored-by: Adolfo R. Brandes <[email protected]> Co-authored-by: Brian Smith <[email protected]> Co-authored-by: Diana Catalina Olarte <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR intends to add CSS Variables support to Redwood release.
THE ERROR WITH THE TESTS IS ABOUT CODECOV.
How to test
tutor mounts add path/to/the/clone
tutor config save
JIRA ISSUE DS-918
Evidence