Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(redwood): add css support and cdn compatibility #17

Merged

Conversation

bra-i-am
Copy link

@bra-i-am bra-i-am commented May 16, 2024

Description

This PR intends to add CSS Variables support to Redwood release.

THE ERROR WITH THE TESTS IS ABOUT CODECOV.

How to test

  • Have a Tutor instance (at the moment of Quince, because there is no Redwood Tutor release yet) with MFE plugin and eox-tenant installed
  • Override the default Learning MFE with this new version:
    • Clone the repo and switch to this branch
    • Mount this MFE running tutor mounts add path/to/the/clone
    • Update the environment with tutor config save
  • Add this to the tenant configs:
  "MFE_CONFIG": {
      "PARAGON_THEME_URLS": {
          "core": {
              "url": "https://cdn.jsdelivr.net/combine/npm/@openedx/[email protected]/styles/css/themes/light/utility-classes.min.css,npm/@openedx/[email protected]/dist/core.min.css"
          },
          "defaults": {
              "light": "light"
          },
          "variants": {
              "light": {
                  "url": "https://css-varsify.s3.amazonaws.com/public/c429dc58-a13f-40ed-9f87-c13aac8d9858.css"
              }
          }
      }
  }

JIRA ISSUE DS-918

Evidence

image

@bra-i-am bra-i-am changed the title perf: add runtime theming support to redwood feat(redwood): add css support and cdn compatibility May 16, 2024
@bra-i-am bra-i-am force-pushed the bc/redwood-css-variables-support branch 2 times, most recently from 1195acd to e0f93fb Compare May 17, 2024 16:23
@bra-i-am bra-i-am requested a review from dcoa May 17, 2024 19:20
@bra-i-am bra-i-am marked this pull request as ready for review May 17, 2024 19:33
@bra-i-am bra-i-am force-pushed the bc/redwood-css-variables-support branch from f0d990f to 923483c Compare May 17, 2024 19:39
@dcoa dcoa force-pushed the bc/redwood-css-variables-support branch from 718f3f9 to 9909d17 Compare May 20, 2024 05:23
@dcoa
Copy link
Collaborator

dcoa commented May 20, 2024

could you fix this, please?
image

Copy link
Collaborator

@dcoa dcoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you think you will not need more changes for frontend-platform, you can create the npm package and merge once that package is updated.

@bra-i-am bra-i-am merged commit 9156a05 into ednx-release/redwood.master May 23, 2024
3 of 4 checks passed
@bra-i-am bra-i-am deleted the bc/redwood-css-variables-support branch May 23, 2024 17:31
bra-i-am added a commit that referenced this pull request Jul 23, 2024
* perf: add runtime theming support to redwood

* fix: outline collapsible icons

* fix: solve issue with overlaid input element

* refactor: add frontend-platform dep from npm

* refactor: rename frontend-build github branch

---------

Co-authored-by: Diana Catalina Olarte <[email protected]>
bra-i-am added a commit that referenced this pull request Jul 23, 2024
* perf: add runtime theming support to redwood

* fix: outline collapsible icons

* fix: solve issue with overlaid input element

* refactor: add frontend-platform dep from npm

* refactor: rename frontend-build github branch

---------

Co-authored-by: Diana Catalina Olarte <[email protected]>
bra-i-am added a commit that referenced this pull request Jul 29, 2024
* feat: [FC-0056] courseware sidebar enhancement (openedx#1398)

- Display section and sequence progress
- Add tracking event to the unit button
- Hide the horizontal unit navigation with enabled sidebar navigation

* fix: optimize scroll position observer after video fullscreen exit (openedx#1405)

* feat!: organize plugin slots as components, add footer slot (openedx#1408)

BREAKING CHANGE: slot ids have been changed for consistency
* `sequence_container_plugin` -> `sequence_container_slot`
* `unit_title_plugin` -> `unit_title_slot`

Co-authored-by: Brian Smith <[email protected]>

* feat(redwood): add css support and cdn compatibility  (#17)

* perf: add runtime theming support to redwood

* fix: outline collapsible icons

* fix: solve issue with overlaid input element

* refactor: add frontend-platform dep from npm

* refactor: rename frontend-build github branch

---------

Co-authored-by: Diana Catalina Olarte <[email protected]>

* fix: some variables weren't css-variables

* fix: recreate package-lock

---------

Co-authored-by: Ihor Romaniuk <[email protected]>
Co-authored-by: Adolfo R. Brandes <[email protected]>
Co-authored-by: Brian Smith <[email protected]>
Co-authored-by: Diana Catalina Olarte <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants