Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: show feedbacks when errors happen #15

Merged
merged 2 commits into from
Sep 29, 2023
Merged

feat: show feedbacks when errors happen #15

merged 2 commits into from
Sep 29, 2023

Conversation

bra-i-am
Copy link
Contributor

Description

This PR applies the required changes for showing errors when something goes wrong with some actions in the app

In this case, feedback is shown when:

  • When somebody is trying to execute an action over a validation process, but someone else did it first; for example, a validator chooses a course for validation and another validator tries to choose the same course
    image
  • When a course creator tries to create a validation process for a course that already belongs to one
    image
  • Or when an unknown error is happening
    image

@bra-i-am
feat: show feedbacks when errors happen
62b614f 
* feat: create a new global state for managing error messages
* feat: add a component for showing the error messages
@bra-i-am bra-i-am requested a review from dcoa September 28, 2023 23:11
@dcoa dcoa merged commit 8066cf9 into master Sep 29, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcoa dcoa dcoa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bra-i-am @dcoa