Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf!: add timeout to avoid excess resource consumption #33

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mariajgrimaldi
Copy link
Collaborator

@mariajgrimaldi mariajgrimaldi commented Oct 18, 2024

Description

There's an issue where the building process gets stuck when building an image in quince with themes configured https://github.com/eduNEXT/ednx-strains/actions/runs/11402841451 -- which I'm still researching, so this limitation will stop the job if it hasn't ended in a reasonable time. This change is not intended to fix the issue but to avoid excess resource consumption in similar cases.

@mariajgrimaldi mariajgrimaldi requested a review from a team as a code owner October 18, 2024 12:21
@mariajgrimaldi mariajgrimaldi changed the title feat!: add timeout to avoid excess resource consumption perf!: add timeout to avoid excess resource consumption Oct 18, 2024
@@ -47,6 +47,7 @@ on:
jobs:
build:
runs-on: ubuntu-latest
timeout-minutes: 40
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to author: this could be configurable.

@mariajgrimaldi mariajgrimaldi marked this pull request as draft October 18, 2024 14:24
@mariajgrimaldi mariajgrimaldi removed the request for review from a team October 18, 2024 14:24
@mariajgrimaldi
Copy link
Collaborator Author

I'll convert this to draft for now while I research the quince issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant