feat: allow to pass extra parameters for celery workers #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ian2012
changed the title
Ian2012
force-pushed
the
cag/parameters
branch
8 times, most recently
from
27dda21
to
c858d5d
Compare
Ian2012
force-pushed
the
cag/parameters
branch
from
c858d5d
to
4282cc6
Compare
(cherry picked from commit c858d5d)
Ian2012
force-pushed
the
cag/parameters
branch
from
4282cc6
to
99d58ec
Compare
MoisesGSalas
reviewed
Oct 3, 2024
Comment on lines
+34
to
+36
| {% for setting, value in config.get("extra_params", {}).items() %} | ||
| - "--{{setting}}={{value}}" | ||
| {% endfor %} |
There was a problem hiding this comment.
Maybe we can have the logic for the command in the python code and use a template filter to render the final command.
There was a problem hiding this comment.
I prefer rendering this code on the template, it's just a setting and a value
marbonilla
reviewed
Oct 4, 2024
Comment on lines
+34
to
+36
| {% for setting, value in config.get("extra_params", {}).items() %} | ||
| - "--{{setting}}={{value}}" | ||
| {% endfor %} |
There was a problem hiding this comment.
could this be susceptible to malicious injection of some sort?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows to pass custom parameters to any celery worker deployment