fix: remove pkg_resources for compatibility with python 3.12 #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaferMazu
requested review from
mariajgrimaldi and
MoisesGSalas
and removed request for
mariajgrimaldi
MoisesGSalas
requested changes
May 1, 2024
There was a problem hiding this comment.
You will also need to update the minimum version of tutor required to 17.0.2
tutor-contrib-codejail/setup.py
Line 47 in 4406c7c
importlib-metadata and importlib-resources were added in overhangio/tutor@d99b2fe which was first included in the 17.0.2 release.
MaferMazu
changed the title
|
Nice catch. Thanks, @MoisesGSalas. Do you have other feedback, or are we okay? |
MoisesGSalas
approved these changes
May 2, 2024
|
I won't create a release for this change since we will soon create a release for Redwood. See #50. If you need a release before Redwood, please open an issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR: