Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tvm list command error #68

Merged
merged 2 commits into from
May 15, 2024
Merged

fix: tvm list command error #68

merged 2 commits into from
May 15, 2024

Conversation

luisfelipec95
Copy link
Contributor

@luisfelipec95 luisfelipec95 commented Nov 1, 2023

This PR fixes the following bug: #66

It was removed the dependency distutils which is going to be deprecated in future Python releases in favor of packaging.version. Next, it was necessary to modify the sorter function to take care of the proper way of implementing local version labels and allow packaging.version take the version names properly and create the Version objects that will be compared for sorting

Testing instructions

First, remove previous TVM versions running pip uninstall tutor-version-manager and sudo pip uninstall tutor-version-manager and make sure to use Python version 10

  • Install a TVM version without the solution applied sudo pip install git+https://github.com/eduNEXT/tvm.git
  • Create a project with a numerical name tvm project init 2024 v17.0.4
  • Run tvm list and you'll watch the error
  • Uninstall the previous version sudo pip uninstall tutor-version-manager
  • Install the TVM with the fix sudo pip install git+https://github.com/eduNEXT/tvm.git@lfc/DS-503
  • Run tvm list so you can watch the TVM versions installed properly

JIRA ISSUE DS-891

@Alec4r
Copy link
Member

Alec4r commented Jan 17, 2024

@MaferMazu why are doc checks failing?

@MaferMazu
Copy link
Contributor

MaferMazu commented Jan 17, 2024

Because we need to add a build.os file in our docs, I will open a bug to solve in the next sprints.

Reference: https://blog.readthedocs.com/use-build-os-config/

cc @Alec4r

@MaferMazu MaferMazu linked an issue Apr 17, 2024 that may be closed by this pull request
@bra-i-am bra-i-am requested review from MaferMazu and a team May 3, 2024 15:14
@github-actions github-actions bot added size/s and removed size/xs labels May 3, 2024
@MaferMazu
Copy link
Contributor

MaferMazu commented May 3, 2024

I could replicate the error.
I had Python 3.10 and TVM 2.3.0 (the latest version) and created a project with a numeric name (e.g., v17.0.3@22). Then I ran the tvm list, which failed, as the reporters in #66 said.
Then I installed the version of this PR, and the command tvm list worked as expected.

Thanks, @bra-i-am and @luisfelipec95 , for this fix. ✨

@bra-i-am bra-i-am requested a review from a team May 7, 2024 14:50
@luisfelipec95
Copy link
Contributor Author

Command tvm list worked as expected, thanks @bra-i-am

@luisfelipec95 luisfelipec95 merged commit 53e9427 into main May 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Error running tvm list command
4 participants