fix: build was failing due to deprecated configs & deps compatibility issues #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bra-i-am
force-pushed
the
bc/build-os-bug
branch
2 times, most recently
from
6acd0a5
to
59749aa
Compare
bra-i-am
force-pushed
the
bc/build-os-bug
branch
from
96e8d37
to
59749aa
Compare
bra-i-am
force-pushed
the
bc/build-os-bug
branch
from
485e635
to
8c82d14
Compare
bra-i-am
changed the title
bra-i-am
changed the title
MaferMazu
previously approved these changes
Apr 5, 2024
There was a problem hiding this comment.
I'm not so happy with adding the constraints, but I didn't find a better way to make it work. I think we can go with this now and in the future, try to simplify the documentation or make it similar to the openedx but with our logos to avoid the many constrictions.
Can you help me remove the release variable from the conf.py? It is out of scope, but I think it is a quick fix we can add. If not, don't worry :)
MaferMazu
previously approved these changes
Apr 5, 2024
luisfelipec95
previously approved these changes
Apr 9, 2024
dcoa
previously approved these changes
Apr 9, 2024
bra-i-am
dismissed stale reviews from dcoa, luisfelipec95, and MaferMazu
via
a19f950
MaferMazu
approved these changes
Apr 11, 2024
luisfelipec95
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR intends to fix the issue #70 by adding the
build.osconfig key to the.readthedocsconfig file as shown in readthedocs/readthedocs.org#10290 (comment). Also, this PR adds some constraints (at doc.in) so the dependencies are compatible withSphinx>5.0Ref. https://blog.readthedocs.com/use-build-os-config/
Aditional Information
JIRA ISSUE DS-857