Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pom.xml: Add Automatic-Module-Name to JAR #8

Merged
merged 1 commit into from
Dec 9, 2022

Conversation

msgilligan
Copy link
Contributor

@msgilligan msgilligan commented Dec 9, 2022

I tried to use the driver in an app using the Java Module System. Because the Java Module System assigns a module name based upon the JAR filename converting - to . and the JAR filename contains the substring native (a reserved word), it is not possible to use this JAR with the current generated module name.

Adding an Automatic-Module-Name header fixes the problem.

@eduramiba
Copy link
Owner

Thank you! Did the driver work out for you?

@eduramiba eduramiba merged commit e2af1a2 into eduramiba:master Dec 9, 2022
@msgilligan
Copy link
Contributor Author

msgilligan commented Dec 9, 2022

You're welcome! I got it working on MacBook Pro M1 Max, macOS Ventura 13.0.1 with the built-in 'FaceTime HD Camera' with a few workarounds. I'll create an issue shortly. (Update: See Issue #9 and Issue #10.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants