CA-406953: Fix pointer truncation in assert code

The assert here checks for alignment, so technically truncating the upper bits is not wrong, but use the correct size. Signed-off-by: Edwin Török <[email protected]>
edwintorok · Feb 21, 2025 · 3cd2d4f · 3cd2d4f
1 parent a76d19f
commit 3cd2d4f
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/lib/statefileio.c b/lib/statefileio.c
@@ -39,6 +39,7 @@
 #include <assert.h>
 #include <errno.h>
 #include <pthread.h>
+#include <stdint.h>
 #include <signal.h>
 #include <string.h>
 #include <unistd.h>
@@ -354,7 +355,7 @@ sf_checksum(
 {
     MTC_U32 sum = 0;
 
-    assert((((MTC_U32)p) & 3) == 0 && (((MTC_U32)end) & 3) == 0);
+    assert((((uintptr_t)p) & 3) == 0 && (((uintptr_t)end) & 3) == 0);
 
     while (p < end)
     {