fix: replace pi with txn id

edx · Aug 28, 2024 · f54fde2 · f54fde2
1 parent 78dc550
commit f54fde2
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/commerce_coordinator/apps/commercetools/clients.py b/commerce_coordinator/apps/commercetools/clients.py
@@ -401,20 +401,20 @@ def update_return_payment_state_after_successful_refund(self, order_id: str,
             if not payment_intent_id:
                 payment_intent_id = ''
             logger.info(f'Creating return for order - payment_intent_id: {payment_intent_id}')
+
+            payment = self.get_payment_by_key(payment_intent_id)
+            logger.info(f"Payment found: {payment}")
+            order = self.get_order_by_id(order_id=order_id)
+            transaction_id = find_refund_transaction(order, amount_in_cents)
             update_transaction_id_action = OrderSetReturnItemCustomTypeAction(
                 return_item_id=return_line_item_return_id,
                 type=CTTypeResourceIdentifier(
                     key='returnItemCustomType',
                 ),
                 fields=CTFieldContainer({
-                    'transactionId': payment_intent_id
+                    'transactionId': transaction_id
                 })
             )
-            payment = self.get_payment_by_key(payment_intent_id)
-            logger.info(f"Payment found: {payment}")
-            order = self.get_order_by_id(order_id=order_id)
-            transaction_id = find_refund_transaction(order, amount_in_cents)
-
             return_transaction_return_item_action = PaymentSetTransactionCustomTypeAction(
                 transaction_id=transaction_id,
                 type=CTTypeResourceIdentifier(key='transactionCustomType'),