Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove zendesk #269

Merged
merged 4 commits into from
Sep 3, 2024
Merged

fix: remove zendesk #269

merged 4 commits into from
Sep 3, 2024

Conversation

nyujacky
Copy link
Contributor

Merge checklist:
Check off if complete or not applicable:

  • Documentation updated (not only docstrings)
  • Fixup commits are squashed away
  • Unit tests added/updated
  • Manual testing instructions provided
  • Noted any: Concerns, dependencies, migration issues, deadlines, tickets

Post-merge:

@nyujacky nyujacky marked this pull request as draft August 29, 2024 12:59
Copy link

github-actions bot commented Aug 29, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  commerce_coordinator/apps/commercetools
  utils.py
  commerce_coordinator/apps/commercetools/sub_messages
  tasks.py
  commerce_coordinator/apps/commercetools/tests
  test_utils.py
  commerce_coordinator/apps/commercetools/tests/sub_messages
  test_tasks.py
Project Total  

This report was generated by python-coverage-comment-action

@nyujacky nyujacky marked this pull request as ready for review August 29, 2024 19:59
@grmartin
Copy link
Member

This looks good, but you should also gut the config values and we need to remove the values from edx-internal as well...

@nyujacky nyujacky merged commit fd6209b into main Sep 3, 2024
9 checks passed
@nyujacky nyujacky deleted the jng/SONIC-647 branch September 3, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants