-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Improve logging messages #298
Conversation
0b926dc
to
375eabe
Compare
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
375eabe
to
cd07f5d
Compare
96bc7d1
to
2598127
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see in the ticket ACs that we had to add appropriate errors such as CommerceToolsError
to retries where needed. Have we verified that we don't need to change anything related to this?
Note for merging: please ensure on staging that we get appropriate error badges on DataDog.
2598127
to
a35b631
Compare
Please take a look into this recommendation from @shafqatfarhan as well: https://twou.slack.com/archives/C07UZC8DDSR/p1733148401861559 |
a35b631
to
5a68365
Compare
I have addressed this in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Search in all CC's codebase for debug logs and check if those need to be updated to info/error logs. If not, then remove those debug logs
- Add a retrying count warning log in all celery tasks
- Check if all celery tasks are run in retires with all sorts of exceptions
26e5b6f
to
2acf8ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is picking up shape. Left some comments, we should be good once those are resolved
7f4bfb9
to
64e28fa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shafqatfarhan remind me if I am missing something but we had identified a potential error to add to retry logic in celery task while creating this ticket. I can't exactly remember that.
ce98bcd
to
92bbe6c
Compare
92bbe6c
to
4e9e1db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please test thoroughly on staging server.
4e9e1db
to
b51d5ee
Compare
Description
In this PR, we have enhanced the log messages and adjusted the log levels in the commerce-coordinator. Additionally, we need to review the retry criteria for various tasks triggered by the CT commerce flow to determine if any additional errors should be included in the retry logic.