-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: pkg-config
added to Docker File
#95
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to future proof the update of mysql client in future releases. See: edx/edx-arch-experiments#349
pshiu
approved these changes
Jul 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Glenn. Tests are failing because of an invalid requirements/ci.txt. Running make upgrade
might fix it.
Based on things i found online, this has since been modified. Pinning pip-tools. |
And they removed it from PyPi. codecov/python-standard#31
…u/project-theseus`
This is a guess, but since im upgrading the requirements locally, and i rebuilt my venv... It swapped Python versions to 3.10 instead of 3.8 (the target of our other tooling)... ``` brew install [email protected] python3.8 -m venv .venv . .venv/bin/activate make upgrade ```
grmartin
added a commit
that referenced
this pull request
Sep 5, 2023
* chore: `pkg-config` added to Docker File + PIP Reqs This is to future proof the update of mysql client in future releases. See: edx/edx-arch-experiments#349 * fix: Docker Compose issues * fix: Bringing all pip req.s in line with those used by the code in `2u/project-theseus` * fix: make upgrade on Py3.8 This is a guess, but since im upgrading the requirements locally, and i rebuilt my venv... It swapped Python versions to 3.10 instead of 3.8 (the target of our other tooling)... ``` brew install [email protected] python3.8 -m venv .venv . .venv/bin/activate make upgrade ``` This is based on PR #95
grmartin
added a commit
that referenced
this pull request
Sep 5, 2023
* chore: `pkg-config` added to Docker File + PIP Reqs This is to future proof the update of mysql client in future releases. See: edx/edx-arch-experiments#349 * fix: Docker Compose issues * fix: Bringing all pip req.s in line with those used by the code in `2u/project-theseus` * fix: make upgrade on Py3.8 This is a guess, but since im upgrading the requirements locally, and i rebuilt my venv... It swapped Python versions to 3.10 instead of 3.8 (the target of our other tooling)... ``` brew install [email protected] python3.8 -m venv .venv . .venv/bin/activate make upgrade ``` This is based on PR #95
grmartin
added a commit
that referenced
this pull request
Sep 5, 2023
* chore: `pkg-config` added to Docker File + PIP Reqs This is to future proof the update of mysql client in future releases. See: edx/edx-arch-experiments#349 * fix: Docker Compose issues * fix: Bringing all pip req.s in line with those used by the code in `2u/project-theseus` * fix: make upgrade on Py3.8 This is a guess, but since im upgrading the requirements locally, and i rebuilt my venv... It swapped Python versions to 3.10 instead of 3.8 (the target of our other tooling)... ``` brew install [email protected] python3.8 -m venv .venv . .venv/bin/activate make upgrade ``` This is based on PR #95
pshiu
pushed a commit
that referenced
this pull request
Sep 7, 2023
* chore: `pkg-config` added to Docker File + PIP Reqs This is to future proof the update of mysql client in future releases. See: edx/edx-arch-experiments#349 * fix: Docker Compose issues * fix: Bringing all pip req.s in line with those used by the code in `2u/project-theseus` * fix: make upgrade on Py3.8 This is a guess, but since im upgrading the requirements locally, and i rebuilt my venv... It swapped Python versions to 3.10 instead of 3.8 (the target of our other tooling)... ``` brew install [email protected] python3.8 -m venv .venv . .venv/bin/activate make upgrade ``` This is based on PR #95
pshiu
pushed a commit
that referenced
this pull request
Sep 7, 2023
* chore: `pkg-config` added to Docker File + PIP Reqs This is to future proof the update of mysql client in future releases. See: edx/edx-arch-experiments#349 * fix: Docker Compose issues * fix: Bringing all pip req.s in line with those used by the code in `2u/project-theseus` * fix: make upgrade on Py3.8 This is a guess, but since im upgrading the requirements locally, and i rebuilt my venv... It swapped Python versions to 3.10 instead of 3.8 (the target of our other tooling)... ``` brew install [email protected] python3.8 -m venv .venv . .venv/bin/activate make upgrade ``` This is based on PR #95
pshiu
pushed a commit
that referenced
this pull request
Dec 11, 2023
* chore: `pkg-config` added to Docker File + PIP Reqs This is to future proof the update of mysql client in future releases. See: edx/edx-arch-experiments#349 * fix: Docker Compose issues * fix: Bringing all pip req.s in line with those used by the code in `2u/project-theseus` * fix: make upgrade on Py3.8 This is a guess, but since im upgrading the requirements locally, and i rebuilt my venv... It swapped Python versions to 3.10 instead of 3.8 (the target of our other tooling)... ``` brew install [email protected] python3.8 -m venv .venv . .venv/bin/activate make upgrade ``` This is based on PR #95
pshiu
pushed a commit
that referenced
this pull request
Dec 11, 2023
* chore: `pkg-config` added to Docker File + PIP Reqs This is to future proof the update of mysql client in future releases. See: edx/edx-arch-experiments#349 * fix: Docker Compose issues * fix: Bringing all pip req.s in line with those used by the code in `2u/project-theseus` * fix: make upgrade on Py3.8 This is a guess, but since im upgrading the requirements locally, and i rebuilt my venv... It swapped Python versions to 3.10 instead of 3.8 (the target of our other tooling)... ``` brew install [email protected] python3.8 -m venv .venv . .venv/bin/activate make upgrade ``` This is based on PR #95
pshiu
pushed a commit
that referenced
this pull request
Dec 11, 2023
* chore: `pkg-config` added to Docker File + PIP Reqs This is to future proof the update of mysql client in future releases. See: edx/edx-arch-experiments#349 * fix: Docker Compose issues * fix: Bringing all pip req.s in line with those used by the code in `2u/project-theseus` * fix: make upgrade on Py3.8 This is a guess, but since im upgrading the requirements locally, and i rebuilt my venv... It swapped Python versions to 3.10 instead of 3.8 (the target of our other tooling)... ``` brew install [email protected] python3.8 -m venv .venv . .venv/bin/activate make upgrade ``` This is based on PR #95
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to future proof the update of mysql client in future releases. See: edx/edx-arch-experiments#349