feat: Enable ConfigWatcher in CMS; prefix Slack messages with IDA name #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces `CONFIG_WATCHER_SERVER_NAME` to support messaging from multiple services. Also: - Add a README for the plugin. - Add start of unit tests in ConfigWatcher - Soft-import waffle The new unit tests were failing because waffle isn't actually a declared dependency, so we switch to `import_string`. This also moves us closer to being able to configure the plugin app entirely using Django settings (rather than a hardcoded model dict).
6 tasks
dianakhuang
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces
CONFIG_WATCHER_SERVER_NAMEto support messaging from multiple services.Merge checklist:
Check off if complete or not applicable: