Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add datadog_diagnostics plugin app #722

Merged
merged 2 commits into from
Jul 10, 2024
Merged

feat: Add datadog_diagnostics plugin app #722

merged 2 commits into from
Jul 10, 2024

Commits on Jul 10, 2024

  1. feat: Add datadog_diagnostics plugin app 

    See #692

Testing setup:
https://2u-internal.atlassian.net/wiki/spaces/ENG/pages/1173618788/Running+Datadog+in+devstack

And then in lms-shell:

```
make requirements
pip install ddtrace
pip install -e /edx/src/archexp/
./wrap-datadog.sh ./server.sh
```

Expect to see this log message:
`Attached MissingSpanProccessor for Datadog diagnostics`

NOTE: This prints "Spans created = 0; spans finished = 0" in devstack when
shut down with ctrl-c, but not when restarted due to autoreload (where it
prints correct info). Something is initializing Django twice and one span
processor is getting span info while the other is printing at shutdown.
There's more to debug here, but it seems stable enough to least try
deploying it.
    @timmc-edx
    timmc-edx committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    8e4828c View commit details
    Browse the repository at this point in the history

  2. fixup! typo in class name

    @timmc-edx
    timmc-edx committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    58b1e27 View commit details
    Browse the repository at this point in the history