feat: launch instructor tool #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zacharis278
force-pushed
the
zhancock/instructor-launch
branch
from
2500620
to
55b1d65
Compare
zacharis278
force-pushed
the
zhancock/instructor-launch
branch
from
3542982
to
eed3d50
Compare
zacharis278
commented
Jun 27, 2023
|
|
||
| self.exam = Exam.objects.create( | ||
| resource_id=str(uuid.uuid4()), | ||
| self.exam = ExamFactory( |
There was a problem hiding this comment.
this is just a refactor to remove more verbose data setup and replace it with factory methods.
zacharis278
force-pushed
the
zhancock/instructor-launch
branch
from
32a1f80
to
de9d178
Compare
alangsto
reviewed
Jun 28, 2023
edx_exams/apps/core/api.py
Outdated
| @@ -299,6 +299,17 @@ def get_exam_by_content_id(course_id, content_id): | |||
| return None | |||
|
|
|||
|
|
|||
| def get_exam_by_id(exam_id): | |||
| """ | |||
| Retrieve an exam filtered by a course_id and content_id | |||
There was a problem hiding this comment.
Nit: comment does not match what the function is using to filter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MST-1948
Creates a new view that will initiate a basic LTI 1.3 launch into the proctoring vendor's instructor tool. I opted to make this a view since returning the URL just adds an extra step to the UI to fetch it and stick it in an iframe. This way we just load up an iframe with
src=http://edx-exams.edx.org/lti/exam/28/instructor_tooland this view does the rest.Original concept was to build a generic launch view into the lti-consumer library based on this POC openedx/xblock-lti-consumer#386. That PR documents the issues I found with that approach.