feat: exam end return url #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zacharis278
commented
Sep 12, 2023
| @@ -303,6 +298,11 @@ def end_assessment(request, attempt_id): | |||
| # Platform MUST send an End Assessment message to the Proctoring Tool. Otherwise, the Assessment Platform can | |||
| # complete its normal post-assessment flow. | |||
| if end_assessment_return: | |||
| # user is authenticated via JWT so use that to create a | |||
There was a problem hiding this comment.
I moved this since it's only necessary if we're performing an end assessment launch
zacharis278
commented
Sep 12, 2023
| @@ -328,7 +329,7 @@ def end_assessment(request, attempt_id): | |||
|
|
|||
| return redirect(preflight_url) | |||
|
|
|||
| return JsonResponse({}) | |||
| return redirect(get_exam_url_path(exam.course_id, exam.content_id)) | |||
There was a problem hiding this comment.
this will leave us on a blank page with '{}'. If we don't need to perform an LtiEndAssessment launch return to the exam section.
zacharis278
force-pushed
the
zhancock/end-assessment-return
branch
3 times, most recently
from
bd13db5
to
7c80239
Compare
alangsto
approved these changes
Sep 12, 2023
zacharis278
force-pushed
the
zhancock/end-assessment-return
branch
from
7c80239
to
55c576b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: MST-2099
Description: Sets a return url for the proctoring tool when performing an LtiEndAssessment launch
Required so tool can properly redirect learner back after ending the assessment once openedx/frontend-lib-special-exams#117 is implemented.