feat: delete allowance #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||
zacharis278
force-pushed
the
zhancock/delete-allowance
branch
2 times, most recently
from
3f11790
to
6eaea58
Compare
zacharis278
force-pushed
the
zhancock/delete-allowance
branch
from
6eaea58
to
f9d0216
Compare
varshamenon4
approved these changes
Jul 31, 2024
| @@ -1878,6 +1880,38 @@ def test_get_empty_response(self): | |||
| self.assertEqual(response.status_code, 200) | |||
| self.assertEqual(response.data, []) | |||
|
|
|||
| def test_delete(self): | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: COSMO-395 (2u-internal)
Description: Endpoint to delete allowances
Note I also added an authorization check to the post endpoint. We authorize the user against the course id passed into the view so we should only ever allow them to create/modify/delete allowances for exams in that course.