fix: address review feedback

edx · Jan 22, 2025 · ce763d3 · ce763d3
1 parent 03fd971
commit ce763d3
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/Discussion/Discussion/Presentation/Posts/PostsView.swift b/Discussion/Discussion/Presentation/Posts/PostsView.swift
@@ -229,7 +229,7 @@ public struct PostsView: View {
                 }
             }
             .onFirstAppear {
-                if viewModel.type != .allPosts && viewModel.type != .followingPosts {
+                if viewModel.isNotAllOrFollowingPosts() {
                     viewModel.trackDiscussionTopicViewed(
                         courseID: courseID,
                         topicID: topicID ?? ""

diff --git a/Discussion/Discussion/Presentation/Posts/PostsViewModel.swift b/Discussion/Discussion/Presentation/Posts/PostsViewModel.swift
@@ -275,6 +275,10 @@ public class PostsViewModel: ObservableObject {
         self.filteredPosts = self.discussionPosts
     }
 
+    func isNotAllOrFollowingPosts() -> Bool {
+        return type != .allPosts && type != .followingPosts
+    }
+
     func trackDiscussionTopicViewed(
         courseID: String,
         topicID: String