feat: add notification project/framework for notification work #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saeedbashir
force-pushed
the
saeed/notification_project
branch
from
a4948fe to
0f8cc42
Compare
|
@saeedbashir Unit tests are failing. Please take a look. |
saeedbashir
force-pushed
the
saeed/notification_project
branch
from
318c90c to
3a89128
Compare
|
@saeedbashir Kindly update the script to assign the Notification sub-project team. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
Notificationsproject/framework in the project for all notification-related work, so moving to the plugin architecture will be easy as all the files will be in the Notification framework.Note: Adding it before hand so everyone can add their work in the same framework.